DAW/daw-lua-common

Fork 0

fix: yaml uses error() instead of nil, err -- inconsistent API #23

New issue

Closed

opened 2026-05-25 17:57:40 +02:00 by michael · 1 comment

michael commented

2026-05-25 17:57:40 +02:00

Owner

Problem

yaml.load_file and parse_map use error() instead of returning
nil, err like the rest of daw.common.

This forces callers to wrap every yaml.load_file call in pcall,
which is inconsistent with how other daw.common modules work.

Fix

load_file: return nil, "[ERROR] yaml: cannot open file: " .. path
parse_map: propagate error as return value instead of throwing

Also

Header path comment is outdated: says src/daw/lua/common/yaml.lua
and usage example shows daw.lua.common.yaml -- both should be
daw/common/yaml.lua and daw.common.yaml.

## Problem `yaml.load_file` and `parse_map` use `error()` instead of returning `nil, err` like the rest of daw.common. This forces callers to wrap every yaml.load_file call in pcall, which is inconsistent with how other daw.common modules work. ## Fix - `load_file`: return `nil, "[ERROR] yaml: cannot open file: " .. path` - `parse_map`: propagate error as return value instead of throwing ## Also Header path comment is outdated: says `src/daw/lua/common/yaml.lua` and usage example shows `daw.lua.common.yaml` -- both should be `daw/common/yaml.lua` and `daw.common.yaml`.

michael added the

labels

2026-05-25 17:57:40 +02:00

michael referenced this issue

2026-05-25 19:10:25 +02:00

fix: yaml.load_file uses io.open directly -- delegate to fs or remove #24

michael referenced this issue

2026-05-25 19:10:26 +02:00

fix: json encode and decode use error() instead of nil, err #25

michael referenced this issue

2026-05-25 19:33:05 +02:00

fix: update outdated header paths and usage examples (daw.lua.common -> daw.common) #30

michael commented

2026-07-19 17:55:32 +02:00

Author

Owner

parse_map/parse_seq/parse_block now return (node, next_i, err) instead of throwing. Nil is reserved exclusively for the error channel -- an empty/absent block returns {} on success, not nil, resolving the ambiguity that a naive nil,err conversion would have created (nil previously meant both 'legitimately empty' and 'parse error'). Verified against reconstructed tenant.yaml / uk_ebook_zero.yaml structures plus the nested-sequence-of-maps path (parse_seq calling parse_map recursively).

michael

2026-07-19 17:55:33 +02:00

closed this issue
added
status
done
and removed
status
to-go
labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

DAW/daw-lua-common#23

No description provided.

Rows
Columns