fix: json encode and decode use error() instead of nil, err #25

New issue

Closed

opened 2026-05-25 19:10:26 +02:00 by michael · 2 comments

michael commented

2026-05-25 19:10:26 +02:00

Owner

Problem

encode_value is a recursive local function that calls error() on
unsupported types. Returning nil, err through all recursion levels is
not trivial.

Proposed fix

Wrap the top-level call in builtin_encode with pcall:

local ok, result = pcall(encode_value, value, ...)
if not ok then return nil, "[ERROR] json: " .. result end
return result

## Problem `encode_value` is a recursive local function that calls `error()` on unsupported types. Returning nil, err through all recursion levels is not trivial. ## Proposed fix Wrap the top-level call in `builtin_encode` with pcall: local ok, result = pcall(encode_value, value, ...) if not ok then return nil, "[ERROR] json: " .. result end return result ## See also - DAW/daw-lua-common#23 (same pattern in yaml.lua)

michael added the

labels

2026-05-25 19:10:26 +02:00

michael changed title from ~~fix: encode_value uses error() instead of nil, err~~ to fix: json encode and decode use error() instead of nil, err

2026-05-25 19:11:49 +02:00

michael commented

2026-05-25 19:11:50 +02:00

Author

Owner

Scope expanded: decode.lua has the same pattern in all three backends (cjson, dkjson, pure-lua). Fix must cover both encode_value and builtin_decode plus the cjson/dkjson wrappers.

michael referenced this issue from DAW/daw-lua-net

2026-05-25 19:57:47 +02:00

fix: http_client -- unprotected require, json.decode can throw #2

michael commented

2026-07-19 17:55:25 +02:00

Author

Owner

builtin_decode's four mutually-recursive functions (decode_string/object/array/value) now thread (value, err) explicitly -- err checked separately from value, since JSON null legitimately decodes to nil. Same pattern applied to encode_value. Also fixed: the cjson branch's pcall(cjson.decode, ...) was catching the error and immediately re-throwing it (error(result)) -- now returns nil, err. cjson encode was previously unprotected (M.encode = cjson.encode directly); now wrapped in pcall for parity with decode.

michael

2026-07-19 17:55:26 +02:00