fix: yaml.load_file uses io.open directly -- delegate to fs or remove #24

New issue

Closed

opened 2026-05-25 19:10:24 +02:00 by michael · 1 comment

michael commented

2026-05-25 19:10:24 +02:00

Owner

Problem

yaml.load_file uses io.open directly. Pure data parsers in
daw.common do not do filesystem access -- that belongs in fs.lua.

Options

Remove yaml.load_file, callers use fs.read_file + yaml.load
Keep yaml.load_file but delegate to fs.read_file internally
(requires yaml.lua to depend on daw.common.fs)

Decision needed

How many callers use yaml.load_file directly?
If few: remove it. If many: delegate to fs.

## Problem `yaml.load_file` uses `io.open` directly. Pure data parsers in daw.common do not do filesystem access -- that belongs in fs.lua. ## Options - Remove `yaml.load_file`, callers use `fs.read_file` + `yaml.load` - Keep `yaml.load_file` but delegate to `fs.read_file` internally (requires yaml.lua to depend on daw.common.fs) ## Decision needed How many callers use `yaml.load_file` directly? If few: remove it. If many: delegate to fs. ## See also - DAW/daw-lua-common#23 (error() vs nil, err in yaml)

michael added the

labels

2026-05-25 19:10:24 +02:00

michael referenced this issue

2026-05-25 19:13:25 +02:00

fix: config_parser uses error() and io.open directly #26