fix: lang.resolve_lang pulls os.getenv directly -- violates DAW architecture #8

New issue

Closed

opened 2026-05-25 20:45:03 +02:00 by michael · 2 comments

michael commented

2026-05-25 20:45:03 +02:00

Owner

Problem

lang.resolve_lang calls os.getenv("LC_ALL") and os.getenv("LANG")
directly. This violates the DAW architecture principle:

Only main is responsible for the environment. Modules receive what
they need via parameters -- they never reach out to the environment
themselves.

This also makes the function untestable without mocking the OS.

Fix

Remove os.getenv calls from resolve_lang. The caller (main) reads
the environment and passes the lang/locale via ctx:

ctx.lang or ctx.user_locale must be set by main before calling resolve_lang.

If no locale is available, main passes a default -- not the module.

## Problem `lang.resolve_lang` calls `os.getenv("LC_ALL")` and `os.getenv("LANG")` directly. This violates the DAW architecture principle: Only main is responsible for the environment. Modules receive what they need via parameters -- they never reach out to the environment themselves. This also makes the function untestable without mocking the OS. ## Fix Remove os.getenv calls from resolve_lang. The caller (main) reads the environment and passes the lang/locale via ctx: ctx.lang or ctx.user_locale must be set by main before calling resolve_lang. If no locale is available, main passes a default -- not the module. ## See also - DAW/daw-modul-berhtjan-core#7 (unprotected require in init.lua)

michael added the

labels

2026-05-25 20:45:03 +02:00

michael commented

2026-05-25 20:45:15 +02:00

Author

Owner

Clarification: os.getenv belongs in sys.lua only. sys reads the environment and passes values to config or main. Modules receive lang/locale via ctx -- never via os.getenv directly.

michael commented

2026-05-25 20:46:27 +02:00

Author

Owner

Final clarification: os.getenv belongs in bin/wrapper only. The wrapper reads the OS environment (including LANG/LC_ALL for language fallback) and builds the ctx before calling main. sys.lua provides the getenv wrapper function. Modules and config.lua never call os.getenv directly.

michael referenced this issue

2026-06-02 07:25:43 +02:00

feat(lang): resolve fallback language from config, not hardcoded #10

michael referenced this issue from a commit

2026-06-02 09:04:52 +02:00

fix: route requires through pcall, remove os.getenv from lang

michael closed this issue

2026-06-02 09:04:52 +02:00

michael referenced this issue from a commit

2026-06-02 10:20:54 +02:00

fix: correct suppress rule name and add missing no-error-discard comments