index: fix header path, remove direct os/io calls in update_index #9
Labels
No labels
coordination/cross-repo
coordination/needed
effort
large
effort
medium
effort
small
meta/duplicate
meta/planning
meta/wontfix
priority
high
priority
low
priority
medium
session
blocker
session
handover
session
next
status
blocked
status
done
status
in-progress
status
review
status
to-go
type
admin
type
bug
type
config
type
deployment
type
docs
type
enhancement
type
feature
type
handover
type
infrastructure
type
installation
type
maintenance
type
migration
type
research
type
security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
DAW/daw-module-manager#9
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Findings
1. Wrong prefix in header comment
src/daw/module_manager/index.luashould beindex.lua(nosrc/prefix).2. Direct os.execute calls in update_index
Four
os.executecalls: mkdir, rm -rf, and two cp.Must be replaced with
out:run_rc().Related: DAW/daw-module-manager#8
3. Direct io.stderr:write calls in update_index
Two
io.stderr:write(...)calls instead ofout:write_err().dawio/sys.new()is not used at all inupdate_index.Acceptance Criteria
os.executecalls replaced without:run_rc()io.stderr:writereplaced without:write_err()dawioinitialized consistently in update_index