commands: fix header path, lazy require, hardcoded strings #7

New issue

Open

opened 2026-05-26 05:01:23 +02:00 by michael · 0 comments

michael commented

2026-05-26 05:01:23 +02:00

Owner

Findings

1. Wrong prefix in header comment (init.lua)

src/daw/module_manager/init.lua should be init.lua (no src/ prefix).

2. Lazy require in cmd_list

require("daw.common.sys") is called inside cmd_list() instead of
at the top level. No circular dependency identified. Should be top-level.

3. Hardcoded English strings (cmd_list)

out:write("No modules installed in " .. ctx.modules_dir) and the
format string in the module listing are hardcoded English.
Language resolution not yet applied here.

Tracked in: DAW/daw-modul-berhtjan-cli#6 (language concept)
Note: contribution.json may also need review once language concept is settled.

Acceptance Criteria

Header comment path corrected in init.lua
require("daw.common.sys") moved to top-level in commands.lua
Hardcoded strings flagged for resolution after DAW/daw-modul-berhtjan-cli#6

## Findings ### 1. Wrong prefix in header comment (init.lua) `src/daw/module_manager/init.lua` should be `init.lua` (no `src/` prefix). ### 2. Lazy require in cmd_list `require("daw.common.sys")` is called inside `cmd_list()` instead of at the top level. No circular dependency identified. Should be top-level. ### 3. Hardcoded English strings (cmd_list) `out:write("No modules installed in " .. ctx.modules_dir)` and the format string in the module listing are hardcoded English. Language resolution not yet applied here. Tracked in: DAW/daw-modul-berhtjan-cli#6 (language concept) Note: contribution.json may also need review once language concept is settled. ## Acceptance Criteria - [ ] Header comment path corrected in init.lua - [ ] `require("daw.common.sys")` moved to top-level in commands.lua - [ ] Hardcoded strings flagged for resolution after DAW/daw-modul-berhtjan-cli#6

michael added the

labels

2026-05-26 05:01:23 +02:00