DAW/daw-modul-berhtjan-core

Fork 0

fix: berhtjan-core init.lua -- unprotected require, global _NAME #7

New issue

Closed

opened 2026-05-25 20:34:08 +02:00 by michael · 4 comments

michael commented

2026-05-25 20:34:08 +02:00

Owner

Problems

All five require calls are unprotected -- no pcall.
A missing submodule produces a raw Lua stack trace.

Affected: loader, composer, types, scanner, lang
_NAME is declared without local -- pollutes global namespace.
All other daw modules use local _NAME.

Fix

Add local to _NAME declaration
Wrap each require in pcall with [ERROR] message and exit 10

## Problems 1. All five require calls are unprotected -- no pcall. A missing submodule produces a raw Lua stack trace. Affected: loader, composer, types, scanner, lang 2. `_NAME` is declared without `local` -- pollutes global namespace. All other daw modules use `local _NAME`. ## Fix - Add `local` to _NAME declaration - Wrap each require in pcall with [ERROR] message and exit 10 ## See also - DAW/fragjan#37 (same pattern in fragjan main.lua) - DAW/fragjan#40 (rule: unprotected require)

michael added the

labels

2026-05-25 20:34:08 +02:00

michael commented

2026-05-25 20:40:42 +02:00

Author

Owner

Also: require("daw.common.json") in loader.lua is unprotected -- same fix needed there.

michael referenced this issue

2026-05-25 20:45:03 +02:00

fix: lang.resolve_lang pulls os.getenv directly -- violates DAW architecture #8

michael commented

2026-05-25 20:47:46 +02:00

Author

Owner

Also unprotected require in composer.lua: require("daw.berhtjan_core.types"). Same fix needed there.

michael commented

2026-05-25 20:48:44 +02:00

Author

Owner

scanner.lua: three points:

require("daw.common.fs") unprotected at module level.
require("daw.berhtjan_core.loader") inside load_contributions unprotected.
Dead code in scan_root recursive branch: 'if names' check after 'if not names then return' is always true -- remove.

scanner.lua: three points: 1. require("daw.common.fs") unprotected at module level. 2. require("daw.berhtjan_core.loader") inside load_contributions unprotected. 3. Dead code in scan_root recursive branch: 'if names' check after 'if not names then return' is always true -- remove.

michael referenced this issue from a commit

2026-06-02 09:15:18 +02:00

fix: add local to _NAME, remove dead code in scan_root

michael closed this issue

2026-06-02 09:15:18 +02:00

michael commented

2026-06-02 09:18:37 +02:00

Author

Owner

Fixed:

init.lua: _NAME declared local
scanner.lua: dead code removed (unreachable if names check after nil guard)
All require calls wrapped in pcall with _check_deps pattern (loader, composer, types, scanner, lang)
loader.lua, composer.lua: pcall+_check_deps for module-level requires
scanner.lua: pcall for inline loader require in load_contributions()
All tests passing on Lua 5.1 and 5.4.

Fixed: - init.lua: _NAME declared local - scanner.lua: dead code removed (unreachable if names check after nil guard) - All require calls wrapped in pcall with _check_deps pattern (loader, composer, types, scanner, lang) - loader.lua, composer.lua: pcall+_check_deps for module-level requires - scanner.lua: pcall for inline loader require in load_contributions() All tests passing on Lua 5.1 and 5.4.

michael added

and removed

labels

2026-06-02 09:18:38 +02:00