DAW/daw-modul-berhtjan-cli

Fork 0

fix(architecture): route sys output through adapters, fix violations #7

New issue

Closed

opened 2026-06-01 19:20:14 +02:00 by michael · 1 comment

michael commented

2026-06-01 19:20:14 +02:00

Owner

Problem

render.lua, prompt.lua and dispatch.lua use daw.common.sys directly
instead of routing through adapters/. This violates the DAW architecture
rule: sys is only allowed in adapters/.

Detected by: fragjan code

Violations

render.lua:5 -- daw.common.sys outside adapters/
prompt.lua:5 -- daw.common.sys outside adapters/
dispatch.lua:101 -- daw.common.sys outside adapters/

Required changes

render.lua

Remove module-level sys/out instance
Accept out as parameter in render_form(), render_record(), render_table()
Add return value contract: true, nil | nil, err

prompt.lua

Remove module-level sys/out instance
Accept out as parameter in prompt(), confirm()
Add return value contract: true, nil | nil, err

dispatch.lua

Remove direct daw.common.sys require
Route output through caller-provided out parameter

Additional violations (same run)

dispatch.lua:13,101 -- unprotected require(), use pcall(require, ...)
init.lua:4,5,6 -- unprotected require(), use pcall(require, ...)
prompt.lua:5 -- unprotected require(), use pcall(require, ...)
dispatch.lua:161 -- silent fallback or {}, handle nil return explicitly

Context

render_record() is required by DAW/fragjan#90 (adapters/ui render chain).
adapters/ui will call mod.render_record(record, fields) and expects
true, nil | nil, err as return value.

## Problem render.lua, prompt.lua and dispatch.lua use daw.common.sys directly instead of routing through adapters/. This violates the DAW architecture rule: sys is only allowed in adapters/. Detected by: fragjan code ## Violations - render.lua:5 -- daw.common.sys outside adapters/ - prompt.lua:5 -- daw.common.sys outside adapters/ - dispatch.lua:101 -- daw.common.sys outside adapters/ ## Required changes **render.lua** - Remove module-level sys/out instance - Accept out as parameter in render_form(), render_record(), render_table() - Add return value contract: true, nil | nil, err **prompt.lua** - Remove module-level sys/out instance - Accept out as parameter in prompt(), confirm() - Add return value contract: true, nil | nil, err **dispatch.lua** - Remove direct daw.common.sys require - Route output through caller-provided out parameter ## Additional violations (same run) - dispatch.lua:13,101 -- unprotected require(), use pcall(require, ...) - init.lua:4,5,6 -- unprotected require(), use pcall(require, ...) - prompt.lua:5 -- unprotected require(), use pcall(require, ...) - dispatch.lua:161 -- silent fallback or {}, handle nil return explicitly ## Context render_record() is required by DAW/fragjan#90 (adapters/ui render chain). adapters/ui will call mod.render_record(record, fields) and expects true, nil | nil, err as return value.

michael added the

labels

2026-06-01 19:20:14 +02:00

michael commented

2026-06-02 07:08:37 +02:00

Author

Owner

Fixes applied:

render.lua, prompt.lua, dispatch.lua: replaced direct require() with
pcall+_check_deps() pattern; lazy out init; all exported functions
check deps before execution
init.lua: pcall+error() pattern for module root requires;
suppress comments inline per fragjan convention
dispatch.lua:178: or {} suppress comment inline
.gitignore: added build/ and config/local.mk
sys-outside-adapters violations: closed as invalid; daw.common.sys
is the abstraction layer; no additional adapter needed in modules

fragjan checks: fixtures exclusion and sys-check scope fixed in
DAW/fragjan; suppress mechanism verified working.

All 35 tests passing on Lua 5.1 and 5.4.

Fixes applied: - render.lua, prompt.lua, dispatch.lua: replaced direct require() with pcall+_check_deps() pattern; lazy out init; all exported functions check deps before execution - init.lua: pcall+error() pattern for module root requires; suppress comments inline per fragjan convention - dispatch.lua:178: or {} suppress comment inline - .gitignore: added build/ and config/local.mk - sys-outside-adapters violations: closed as invalid; daw.common.sys is the abstraction layer; no additional adapter needed in modules fragjan checks: fixtures exclusion and sys-check scope fixed in DAW/fragjan; suppress mechanism verified working. All 35 tests passing on Lua 5.1 and 5.4.

michael

2026-06-02 07:08:37 +02:00

closed this issue
added
status
done
and removed
status
to-go
labels

michael referenced this issue from a commit

2026-06-02 09:35:37 +02:00

fix: route requires through pcall, fix gitignore and fragjan violations

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

DAW/daw-modul-berhtjan-cli#7

No description provided.

Rows
Columns