Makefile: install target points to non-existent src/ directory #13

Closed
opened 2026-09-20 19:30:16 +02:00 by michael · 0 comments
Owner

Problem

The install target in Makefile copies src/daw/lua/net/*.lua, but
this repository has no src/ directory. The sources (init.lua,
http_client.lua, ip_utils.lua) are in the repository root, so
make install cannot install anything.

The target directory $(DAW_LUA_SHAREDIR)/daw/lua/net also does not
match the module name daw.net; daw-lua-common installs to
$(DAW_LUA_SHAREDIR)/daw/common/.

Scope

  • Fix the source and target paths of install and uninstall so they
    match the actual layout and the module name.
  • Decide whether i18n/*.json must be installed with the module. The
    Makefile of DAW/daw-lua-common does not install its i18n/ either,
    so the answer should be the same for both repositories.
  • Do not mix this with other Makefile cleanup.

Acceptance criteria

  • make install installs the module files to the correct location
  • make uninstall removes exactly what install created
  • Decision on i18n/ recorded (installed or explicitly not)
  • fragjan code . and make test (5.1 and 5.4) pass

DAW/daw-lua-net#10 (noticed during the resource_id migration)
DAW/daw-lua-common (same question for i18n/)

## Problem The `install` target in `Makefile` copies `src/daw/lua/net/*.lua`, but this repository has no `src/` directory. The sources (`init.lua`, `http_client.lua`, `ip_utils.lua`) are in the repository root, so `make install` cannot install anything. The target directory `$(DAW_LUA_SHAREDIR)/daw/lua/net` also does not match the module name `daw.net`; daw-lua-common installs to `$(DAW_LUA_SHAREDIR)/daw/common/`. ## Scope - Fix the source and target paths of `install` and `uninstall` so they match the actual layout and the module name. - Decide whether `i18n/*.json` must be installed with the module. The Makefile of DAW/daw-lua-common does not install its `i18n/` either, so the answer should be the same for both repositories. - Do not mix this with other Makefile cleanup. ## Acceptance criteria - [ ] `make install` installs the module files to the correct location - [ ] `make uninstall` removes exactly what `install` created - [ ] Decision on `i18n/` recorded (installed or explicitly not) - [ ] fragjan code . and make test (5.1 and 5.4) pass ## Related DAW/daw-lua-net#10 (noticed during the resource_id migration) DAW/daw-lua-common (same question for i18n/)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
DAW/daw-lua-net#13
No description provided.