Audit run_rc()/run() callers for correct cause vs. raw-output distinction #56

New issue

Open

opened 2026-08-16 08:58:54 +02:00 by michael · 0 comments

michael commented

2026-08-16 08:58:54 +02:00

Owner

Problem

fs/dir.lua's remove_dir_recursive() currently (pre-#48-fix) passes
sys:run_rc()'s second return value as cause in both branches:

local rc, output = sys:run_rc("rm -rf -- " .. shell_quote(path))
if rc == nil then
  return err("rm_failed", "rm invocation failed", { cause = output, data = { path = path } })
end

sys.lua's run_rc() contract: on infrastructure failure it returns
nil, daw_error/v1 (output is a valid cause there); on a completed
process with non-zero exit, it returns rc, stdout (output is raw
process text, never a daw_error/v1, and must not be used as cause).

Found and fixed for fs/dir.lua's own two call sites during the
daw_i18n/v1 migration (DAW/daw-lua-common#48). This issue is to audit
whether other run_rc()/run() callers in the library make the same
mistake.

Scope

Audit all run_rc()/run() callers for the rc==nil vs rc!=0 (or
equivalent) distinction
Confirm cause is only ever set to an actual daw_error/v1

DAW/daw-lua-common#48

## Problem `fs/dir.lua`'s `remove_dir_recursive()` currently (pre-#48-fix) passes `sys:run_rc()`'s second return value as `cause` in both branches: ```lua local rc, output = sys:run_rc("rm -rf -- " .. shell_quote(path)) if rc == nil then return err("rm_failed", "rm invocation failed", { cause = output, data = { path = path } }) end ``` `sys.lua`'s `run_rc()` contract: on infrastructure failure it returns `nil, daw_error/v1` (output is a valid cause there); on a completed process with non-zero exit, it returns `rc, stdout` (output is raw process text, never a daw_error/v1, and must not be used as `cause`). Found and fixed for fs/dir.lua's own two call sites during the daw_i18n/v1 migration (DAW/daw-lua-common#48). This issue is to audit whether other run_rc()/run() callers in the library make the same mistake. ## Scope - Audit all run_rc()/run() callers for the rc==nil vs rc!=0 (or equivalent) distinction - Confirm cause is only ever set to an actual daw_error/v1 ## Related DAW/daw-lua-common#48

michael added the

labels

2026-08-16 08:58:54 +02:00

michael referenced this issue from a commit

2026-08-16 09:36:22 +02:00

feat(i18n): add resource_id to all fs/ error sites