Migrate all internal error origins to daw_error/v1

michael commented

2026-08-14 17:31:59 +02:00

Owner

Problem

daw-lua-common still contains internal helpers that create or propagate
plain error strings. The i18n migration exposed that callers may then
reuse opaque helper text as the complete message of a new error,
losing origin, code, structured data, identity, and causality.

Concrete example: crypto/hash.lua.

Goal

Before continuing the broad daw_i18n/v1 migration, review all Lua
source files and move structured error creation to the actual point of
failure.

Scope

For every Lua error path:

identify where the error is first detected;
create daw_error/v1 there;
preserve relevant structured data;
propagate unchanged when no new semantic error is introduced;
use cause for a distinct higher-level error;
remove plain-string error propagation;
do not silently discard errors;
preserve public return arity and successful behavior.

Do not perform unrelated refactoring.

This issue blocks further repository-wide work on DAW/daw-lua-common#48
so i18n is applied only after the final set of error origins is stable.

Acceptance criteria

Every Lua source file has been reviewed.
Every actual error state is represented as daw_error/v1 at its origin.
No helper-propagated plain error strings remain in runtime error paths.
Higher-level errors preserve lower-level errors via cause where appropriate.
No silent error discard remains.
Existing public return contracts remain valid.
fragjan code . passes.
make test passes under Lua 5.1 and Lua 5.4.
DAW/daw-lua-common#48 can resume against a stable set of error sites.

DAW/daw-lua-common#48
DAW/daw-lua-common#49
daw_error/v1

## Problem `daw-lua-common` still contains internal helpers that create or propagate plain error strings. The i18n migration exposed that callers may then reuse opaque helper text as the complete `message` of a new error, losing origin, code, structured data, identity, and causality. Concrete example: `crypto/hash.lua`. ## Goal Before continuing the broad `daw_i18n/v1` migration, review all Lua source files and move structured error creation to the actual point of failure. ## Scope For every Lua error path: - identify where the error is first detected; - create `daw_error/v1` there; - preserve relevant structured data; - propagate unchanged when no new semantic error is introduced; - use `cause` for a distinct higher-level error; - remove plain-string error propagation; - do not silently discard errors; - preserve public return arity and successful behavior. Do not perform unrelated refactoring. This issue blocks further repository-wide work on `DAW/daw-lua-common#48` so i18n is applied only after the final set of error origins is stable. ## Acceptance criteria - [ ] Every Lua source file has been reviewed. - [ ] Every actual error state is represented as `daw_error/v1` at its origin. - [ ] No helper-propagated plain error strings remain in runtime error paths. - [ ] Higher-level errors preserve lower-level errors via `cause` where appropriate. - [ ] No silent error discard remains. - [ ] Existing public return contracts remain valid. - [ ] `fragjan code .` passes. - [ ] `make test` passes under Lua 5.1 and Lua 5.4. - [ ] `DAW/daw-lua-common#48` can resume against a stable set of error sites. ## Related - `DAW/daw-lua-common#48` - `DAW/daw-lua-common#49` - `daw_error/v1`

michael added the

labels

2026-08-14 17:31:59 +02:00

~~michael referenced this issue 2026-08-14 20:33:32 +02:00~~

fix: yaml uses error() instead of nil, err -- inconsistent API #23