Add fs.remove_dir_recursive() for temp directory cleanup

michael commented

2026-07-19 05:53:00 +02:00

Owner

daw.common.fs currently has no equivalent to 'rm -rf' for recursive directory removal. fs.remove() only handles single files / empty directories via os.remove().

Use case: daw-module-manager/sig.lua creates a temp dir via fs.tmpdir() (mktemp -d) to hold a pubkey during signature verification, and needs to clean it up afterwards -- currently falls back to sys:run_rc('rm -rf ' .. dir) directly in program code, which daw-code-standard.md flags as a violation (external calls belong in common/adapters).

Needs: fs.remove_dir_recursive(path) -> true, nil | nil, err. Should probably build on fs.list_files/fs.list_dirs recursion + fs.remove, or shell out via daw.common.sys internally (fs is allowed to use sys, program code is not).

Related: DAW/daw-module-manager (sig.lua TMPDIR cleanup).

daw.common.fs currently has no equivalent to 'rm -rf' for recursive directory removal. fs.remove() only handles single files / empty directories via os.remove(). Use case: daw-module-manager/sig.lua creates a temp dir via fs.tmpdir() (mktemp -d) to hold a pubkey during signature verification, and needs to clean it up afterwards -- currently falls back to sys:run_rc('rm -rf ' .. dir) directly in program code, which daw-code-standard.md flags as a violation (external calls belong in common/adapters). Needs: fs.remove_dir_recursive(path) -> true, nil | nil, err. Should probably build on fs.list_files/fs.list_dirs recursion + fs.remove, or shell out via daw.common.sys internally (fs is allowed to use sys, program code is not). Related: DAW/daw-module-manager (sig.lua TMPDIR cleanup).

michael added the

coordination/cross-repo

labels

2026-07-19 05:53:00 +02:00

michael commented

2026-07-19 17:46:52 +02:00

Author

Owner

Implemented in fs/dir.lua, shells out via daw.common.sys (rm -rf). Wired into fs/init.lua and dev-module-map.lua. Tested in test_fs.lua including the guardrails against path == "/" or "".

michael commented

2026-07-19 17:47:52 +02:00

Author

Owner

Implemented in fs/dir.lua, shells out via daw.common.sys (rm -rf). Wired into fs/init.lua and dev-module-map.lua. Tested in test_fs.lua including the guardrails against path == "/" or "".

michael added

and removed

labels

2026-07-19 17:51:53 +02:00

michael commented

2026-07-19 17:54:58 +02:00

Author

Owner

Implemented in fs/dir.lua, shells out via daw.common.sys (rm -rf). Wired into fs/init.lua and dev-module-map.lua. Tested in test_fs.lua including the guardrails against path == "/" or "".

michael closed this issue

2026-07-19 17:55:01 +02:00

michael referenced this issue from a commit

2026-07-20 07:16:36 +02:00

refactor!(common): unify error handling and remove hidden dependencies across daw-lua-common

Rows
Columns

Add fs.remove_dir_recursive() for temp directory cleanup #36