chore(daw-lua-common): remove obsolete suppress annotations after no-temp-dir-literal fix #34

Closed
opened 2026-06-04 20:27:40 +02:00 by michael · 1 comment
Owner

Context

The rule no-temp-dir-literal was updated to use pattern primitive with
pattern '".temp"' instead of the old contains match on '.temp'.

The old pattern caused false positives on Lua module name strings like
"daw.common.fs.temp", which required suppress annotations.

Task

Remove now-unnecessary suppress annotations from daw-lua-common:

  • lib/daw/common/fs/init.lua line 26
  • lib/daw/common/fs/temp.lua line 6

Both contain: -- fragjan: suppress no-temp-dir-literal -- module name, not a path

Acceptance criteria

  • suppress annotation removed from lib/daw/common/fs/init.lua
  • suppress annotation removed from lib/daw/common/fs/temp.lua
  • fragjan runs clean on daw-lua-common after removal

References

## Context The rule no-temp-dir-literal was updated to use pattern primitive with pattern '".temp"' instead of the old contains match on '.temp'. The old pattern caused false positives on Lua module name strings like "daw.common.fs.temp", which required suppress annotations. ## Task Remove now-unnecessary suppress annotations from daw-lua-common: - lib/daw/common/fs/init.lua line 26 - lib/daw/common/fs/temp.lua line 6 Both contain: -- fragjan: suppress no-temp-dir-literal -- module name, not a path ## Acceptance criteria - [ ] suppress annotation removed from lib/daw/common/fs/init.lua - [ ] suppress annotation removed from lib/daw/common/fs/temp.lua - [ ] fragjan runs clean on daw-lua-common after removal ## References - DAW/fragjan#119 -- original false positive bug
Author
Owner

Removed from fs/init.lua:26 and fs/temp.lua:6. fragjan runs clean without them.

Removed from fs/init.lua:26 and fs/temp.lua:6. fragjan runs clean without them.
michael 2026-07-19 17:55:06 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
DAW/daw-lua-common#34
No description provided.